Repository navigation
Allow platinum wallets to transact - #29395
Conversation
Deploying with
|
| Latest commit: |
f7f785c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://681211ee.helpdot.pages.dev |
| Branch Preview URL: | https://cole-platinum-wallets.helpdot.pages.dev |
|
🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪 |
MariaHCD
left a comment
There was a problem hiding this comment.
LGTM, I can work on the reviewer checklist and testing this.
Probably worth mentioning in the QA steps that this should be done internally.
| function ActivateStep(props) { | ||
| const isGoldWallet = props.userWallet.tierName === CONST.WALLET.TIER_NAME.GOLD; | ||
| const animation = isGoldWallet ? LottieAnimations.Fireworks : LottieAnimations.ReviewingBankInfo; | ||
| const isActivedWallet = _.contains([CONST.WALLET.TIER_NAME.GOLD, CONST.WALLET.TIER_NAME.PLATINUM], props.userWallet.tierName); |
There was a problem hiding this comment.
| const isActivedWallet = _.contains([CONST.WALLET.TIER_NAME.GOLD, CONST.WALLET.TIER_NAME.PLATINUM], props.userWallet.tierName); | |
| const isActivatedWallet = _.contains([CONST.WALLET.TIER_NAME.GOLD, CONST.WALLET.TIER_NAME.PLATINUM], props.userWallet.tierName); |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-13.at.5.45.39.PM.movScreen.Recording.2023-10-13.at.5.47.40.PM.movMobile Web - ChromeScreen.Recording.2023-10-13.at.6.34.09.PM.movMobile Web - SafariScreen.Recording.2023-10-13.at.6.08.24.PM.moviOSAndroidScreen.Recording.2023-10-13.at.6.32.26.PM.mov |
|
Having issues with the iOS simulator but other platforms look good |
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
MonilBhavsar
left a comment
There was a problem hiding this comment.
Looks good! If this is Internal QA, should we add appropriate label
| const hasGoldWallet = this.props.userWallet.tierName && this.props.userWallet.tierName === CONST.WALLET.TIER_NAME.GOLD; | ||
| if (!hasGoldWallet) { | ||
| Log.info('[KYC Wallet] User does not have gold wallet'); | ||
| const hasActivatedWallet = this.props.userWallet.tierName && _.contains([CONST.WALLET.TIER_NAME.GOLD, CONST.WALLET.TIER_NAME.PLATINUM], this.props.userWallet.tierName); |
There was a problem hiding this comment.
NAB, we can have a separate method to check if wallet is one of those specific tiers
There was a problem hiding this comment.
I had the same thought but I don't believe we have a model (or some sort of lib) class for Wallets?
|
This will need internal QA, only Expensify employees have platinum wallets for now. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.86-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀
|

@MariaHCD Please review.
This lets you setup and pay with a Platinum Wallet.
Details
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/325500
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop